-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc that WaitForFirstConsumer is not supported at restore time #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xing-yang <xingyang105@gmail.com>
lipingxue
reviewed
Feb 27, 2024
deepakkinni
approved these changes
Feb 27, 2024
lipingxue
pushed a commit
to lipingxue/velero-plugin-for-vsphere
that referenced
this pull request
Mar 11, 2024
Signed-off-by: xing-yang <xingyang105@gmail.com>
lipingxue
pushed a commit
to lipingxue/velero-plugin-for-vsphere
that referenced
this pull request
Mar 11, 2024
Signed-off-by: xing-yang <xingyang105@gmail.com> Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue
added a commit
that referenced
this pull request
Mar 11, 2024
* Update support matrix for Vanilla, WCP and GC. (#559) Signed-off-by: Liping Xue <lipingx@vmware.com> * Document change to update known issue. (#560) * Document change. Signed-off-by: Liping Xue <lipingx@vmware.com> * Address comment from Xing. Signed-off-by: Liping Xue <lipingx@vmware.com> * Remove files that are not needed for this change. Signed-off-by: Liping Xue <lipingx@vmware.com> --------- Signed-off-by: Liping Xue <lipingx@vmware.com> * Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#562) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Liping Xue <lipingx@vmware.com> * Update document. (#566) Signed-off-by: Liping Xue <lipingx@vmware.com> * Modify parsing behavior of login credentials to handle Go escape characters (#564) * Signed-off-by: Varun Srinivasan <varuns6@vmware.com> Create common config and new function to parse config data * Always populate "port" key of parameters map after setting default VC port if config port value is empty Signed-off-by: Varun Srinivasan <varuns6@vmware.com> * Clean up test logging and unit tests Signed-off-by: Varun Srinivasan <varuns6@vmware.com> * Keep only necessary config values Signed-off-by: Varun Srinivasan <varuns6@vmware.com> * Refactor ParseConfig to return error for sanitized error handling Signed-off-by: Varun Srinivasan <varuns6@vmware.com> --------- Signed-off-by: Varun Srinivasan <varuns6@vmware.com> Signed-off-by: Liping Xue <lipingx@vmware.com> * Only skip PVC creation if --namespace-mapping flag is not used (#565) * Only skip PVC creation if --namespace-mapping flag is not used Signed-off-by: Varun Srinivasan <varuns6@vmware.com> * Refactor SkipPVCCreation function signature to add target namespace as a parameter Signed-off-by: Varun Srinivasan <varuns6@vmware.com> --------- Signed-off-by: Varun Srinivasan <varuns6@vmware.com> Signed-off-by: Liping Xue <lipingx@vmware.com> * Add doc that wffc is not supported (#567) Signed-off-by: xing-yang <xingyang105@gmail.com> Signed-off-by: Liping Xue <lipingx@vmware.com> * Fail the Restore if the StorageClass is associated with WaitForFirstConsumer volumeBindingMode (#568) Signed-off-by: Deepak Kinni <dkinni@vmware.com> Co-authored-by: Deepak Kinni <dkinni@vmware.com> Signed-off-by: Liping Xue <lipingx@vmware.com> --------- Signed-off-by: Liping Xue <lipingx@vmware.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Varun Srinivasan <varuns6@vmware.com> Signed-off-by: xing-yang <xingyang105@gmail.com> Signed-off-by: Deepak Kinni <dkinni@vmware.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Varun Srinivasan <varun.srinivasan@broadcom.com> Co-authored-by: Xing Yang <xingyang105@gmail.com> Co-authored-by: Deepak Kinni <deepak.kinni@broadcom.com> Co-authored-by: Deepak Kinni <dkinni@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At restore time, StorageClass with WaitForFirstConsumer VolumeBindingMode is not supported. Only StorageClass with Immediate VolumeBindingMode is supported at restore time. Add documentation for this.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
When StorageClass with WaitForFirstConsumer VolumeBindingMode was used at restore time, we got the following "PVC did not become Bound" error.
Does this PR introduce a user-facing change?: